forked from Azure/azure-cli-extensions
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Domains on Managed Environments #152
Merged
runefa
merged 28 commits into
calvinsID:containerapp-0.3.12
from
runefa:envcustomdomains
Sep 15, 2022
Merged
Custom Domains on Managed Environments #152
runefa
merged 28 commits into
calvinsID:containerapp-0.3.12
from
runefa:envcustomdomains
Sep 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug with `az containerapp create`
* Ran tests. * Update src/containerapp/azext_containerapp/_clients.py Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Silas Strawn <[email protected]>
`az containerapp up`: Support No Dockerfile Scenario
Revert "`az containerapp up`: Support No Dockerfile Scenario"
…dockerfile Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario""
runefa
changed the base branch from
containerapp-0.3.11
to
containerapp-0.3.12
September 14, 2022 22:21
StrawnSC
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs the linter fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.