Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Domains on Managed Environments #152

Merged
merged 28 commits into from
Sep 15, 2022

Conversation

runefa
Copy link
Collaborator

@runefa runefa commented Sep 8, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

StrawnSC and others added 26 commits August 1, 2022 14:47
Fix bug with `az containerapp create`
* Ran tests.

* Update src/containerapp/azext_containerapp/_clients.py

Co-authored-by: Silas Strawn <[email protected]>

Co-authored-by: Haroon Feisal <[email protected]>
Co-authored-by: Silas Strawn <[email protected]>
`az containerapp up`: Support No Dockerfile Scenario
Revert "`az containerapp up`: Support No Dockerfile Scenario"
…dockerfile

Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario""
@runefa runefa changed the base branch from containerapp-0.3.11 to containerapp-0.3.12 September 14, 2022 22:21
@runefa runefa marked this pull request as ready for review September 14, 2022 23:04
@runefa runefa requested a review from calvinsID as a code owner September 14, 2022 23:04
@runefa runefa changed the title Envcustomdomains Custom Domains on Managed Environments Sep 14, 2022
Copy link
Collaborator

@StrawnSC StrawnSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs the linter fix

@runefa runefa merged commit 3665e8b into calvinsID:containerapp-0.3.12 Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants